Skip to content

feat(material-experimental/mdc-dialog): switch to new theming api #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

feat(material-experimental/mdc-dialog): switch to new theming api #24521

merged 1 commit into from
Mar 24, 2022

Conversation

@andrewseguin
Copy link
Contributor

Re-opening #23620 - it failed to get into Google. Many tests do not actually open a dialog to screenshot their component, but MDC dialog depends on certain styles provided by the dialog component and container.

Will get this in after providing a utility to make it easier for people to test their dialog tests

@andrewseguin andrewseguin requested a review from devversion as a code owner March 4, 2022 15:36
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent action: merge The PR is ready for merge by the caretaker labels Mar 4, 2022
@andrewseguin andrewseguin requested review from crisbeto and removed request for devversion March 4, 2022 15:36
devversion
devversion approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, never got to the original PR.

@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Mar 4, 2022
@andrewseguin andrewseguin added feature This issue represents a new feature or feature request rather than a bug or bug fix target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release feature This issue represents a new feature or feature request rather than a bug or bug fix labels Mar 24, 2022
@andrewseguin andrewseguin merged commit 0163ad2 into angular:master Mar 24, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@andrewseguin
feat(material-experimental/mdc-dialog): switch to new theming api (an…
8e9aff2 
…gular#23620) (angular#24521)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewseguin @crisbeto @devversion