Skip to content

Revert "feat(material-experimental/mdc-dialog): switch to new theming api (#23620)" #24508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

Revert "feat(material-experimental/mdc-dialog): switch to new theming api (#23620)" #24508

merged 1 commit into from
Mar 2, 2022

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 2, 2022

This reverts commit 353a548.

@andrewseguin andrewseguin requested a review from crisbeto March 2, 2022 18:01
@andrewseguin andrewseguin requested a review from devversion as a code owner March 2, 2022 18:01
@andrewseguin
Copy link
Contributor Author

andrewseguin commented Mar 2, 2022

Actually investinga

@andrewseguin
Copy link
Contributor Author

andrewseguin commented Mar 2, 2022

Going to take a while to figure out what happened. Looks like tests were broken and its not clear the PR is wrong, but it might take time to make fixes in clients. Lets revert for now

@andrewseguin andrewseguin reopened this Mar 2, 2022
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 2, 2022
@andrewseguin andrewseguin merged commit a2de246 into angular:master Mar 2, 2022
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 2, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andrewseguin