refactor(cdk/portal): simplify DomPortalOutlet constructor #24504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
Most of the constructor parameters of `DomPortalOutlet` are only used for component portals. These changes make them optional in order to simplify the constructor. If we hit a code path that does require them, we'll throw a runtime error. Related to the discussion in angular#24334.
crisbeto
force-pushed
the
24334/portal-simplification
branch
from
196399d to
cc455af
Compare
andrewseguin
approved these changes
Mar 24, 2022
andrewseguin
pushed a commit
that referenced
this pull request
Mar 25, 2022
Most of the constructor parameters of `DomPortalOutlet` are only used for component portals. These changes make them optional in order to simplify the constructor. If we hit a code path that does require them, we'll throw a runtime error. Related to the discussion in #24334. (cherry picked from commit a4642cb)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…4504) Most of the constructor parameters of `DomPortalOutlet` are only used for component portals. These changes make them optional in order to simplify the constructor. If we hit a code path that does require them, we'll throw a runtime error. Related to the discussion in angular#24334.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the constructor parameters of
DomPortalOutletare only used for component portals. These changes make them optional in order to simplify the constructor. If we hit a code path that does require them, we'll throw a runtime error.Related to the discussion in #24334.