Skip to content

refactor(material/checkbox): remove xml:space attr from svg checkmark #24461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

refactor(material/checkbox): remove xml:space attr from svg checkmark #24461

merged 1 commit into from
Mar 24, 2022

Conversation

@davidglezz
Copy link
Contributor

@davidglezz davidglezz commented Feb 22, 2022 •
edited
Loading

It seems that it was accidentally added in the first version of the component. unneeded attribute xml:space is removed.

Info about xml:space: http://www.xmlplease.com/xml/xmlspace/

@davidglezz davidglezz closed this Feb 24, 2022
@davidglezz davidglezz reopened this Feb 24, 2022
@davidglezz
Copy link
Contributor Author

davidglezz commented Feb 24, 2022

CLA done

devversion
devversion approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! can you please fix the CLA?

@davidglezz
refactor(material/checkbox): remove xml:space attr from svg checkmark
0253d63 
It seems that it was accidentally added in the first version of the component. unneeded attribute xml:space is removed.
@davidglezz
Copy link
Contributor Author

davidglezz commented Mar 14, 2022

@devversion I have done rebase to re-start CI checks. Now its ✅ .

@devversion devversion added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Mar 14, 2022
@andrewseguin andrewseguin merged commit 2f06a67 into angular:master Mar 24, 2022
andrewseguin pushed a commit that referenced this pull request Mar 24, 2022
@davidglezz @andrewseguin
refactor(material/checkbox): remove xml:space attr from svg checkmark (…
3b2b5ad 
…#24461)

It seems that it was accidentally added in the first version of the component. unneeded attribute xml:space is removed.

(cherry picked from commit 2f06a67)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@davidglezz
refactor(material/checkbox): remove xml:space attr from svg checkmark (…
3dc3c12 
…angular#24461)

It seems that it was accidentally added in the first version of the component. unneeded attribute xml:space is removed.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 24, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2022
@davidglezz davidglezz deleted the patch-1 branch April 24, 2022 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidglezz @devversion @andrewseguin