component(): sidenav.

[hansl]

@jelbourn @robertmesserle @kara

Design:

• https://docs.google.com/document/d/1baTbj5OOkUMpwRLDo23sLMVl5ZQtk8-RgpiL2zTuoUk/edit#

Todo:

• Backdrop
• Unit tests
  • MdSidenav
  • MdSidenavContainer
• LTR/RTL
• container attribute on the drawers.
• display: none when fully closed (after transition end).
• Documentation.
  • MdSidenav
  • MdSidenavContainer
• Side-by-side mode.

[jelbourn]

Color should be defined in terms of the current theme.

[hansl]

Yes, that slipped through :)

[hansl]

Actually, it seems the default background is rgba(0,0,0,0) which I find awkward.

[hansl]

@jelbourn @kara @robertmesserle

Please review style and content, but not tests.

[jelbourn]

Why are there left_ and right_ properties? If they're just aliases, I think that's confusing and prone to errors.

[hansl]

Because left_ and right_ are on the right/left independently of direction, while start/end changes based on direction.

[jelbourn]

Add explanation?

[jelbourn]

cc @juliemr would you be able to take a quick peek at the unit tests here to make sure we're setting ourselves up with good practices?

[juliemr]

What do you gain from declaring fixture out here? Why not just do .then(fixture: ComponentFixture) in each of the tests and save some lines?

[hansl]

@juliemr I am chaining all the promises. In order to do that I'd need to return the fixture for every executor function.

[juliemr]

ah, gotcha. OK, test looks good to me.

[jelbourn]

We should leave the types out of the JsDoc since they're just part of the language

[jelbourn]

LGTM, though tests seem to be failing

[hansl]

It's weird that we have methods that returns something with a @returns JSDoc, and technically the type is non optional. That's probably why WebStorm added the type to it.

Tests are flaky. I'll rerun them until they pass. :/

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}