fix(multiple): some experimental components not cleaned up completely #23994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-components-cleanup-logic
branch
from
1a9ff03 to
63a340f
Compare
crisbeto
force-pushed
the
mdc-components-cleanup-logic
branch
from
63a340f to
c76c614
Compare
Fixes a few cases where we weren't destroying the MDC foundation in our own components. There's also a case where we were overriding the `ngOnDestroy` from a parent component, but we weren't calling it from the override.
crisbeto
force-pushed
the
mdc-components-cleanup-logic
branch
from
c76c614 to
bf68fed
Compare
devversion
approved these changes
Nov 20, 2021
This was referenced Dec 1, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few cases where we weren't destroying the MDC foundation in our own components. There's also a case where we were overriding the
ngOnDestroyfrom a parent component, but we weren't calling it from the override.