Skip to content

fix(cdk/table): Measure column width for sticky columns after new data ha… #23885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix(cdk/table): Measure column width for sticky columns after new data ha… #23885

merged 1 commit into from
Jan 10, 2022

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Nov 3, 2021

…s rendered.

See internal ticket 205018678 for more info and before/after screencasts

@kseamon kseamon requested review from a team and andrewseguin as code owners November 3, 2021 19:20
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2021
@kseamon kseamon force-pushed the table-defer-sticky branch from 88fda14 to 120b05c Compare November 3, 2021 20:58
@kseamon kseamon changed the title fix(table): Measure column width for sticky columns after new data ha… fix(cdk/table): Measure column width for sticky columns after new data ha… Nov 3, 2021
@kseamon kseamon force-pushed the table-defer-sticky branch from 120b05c to 24adfa1 Compare November 3, 2021 21:27
jelbourn
jelbourn reviewed Nov 3, 2021
View reviewed changes
crisbeto
crisbeto reviewed Nov 4, 2021
View reviewed changes
@kseamon kseamon force-pushed the table-defer-sticky branch 2 times, most recently from e251b44 to b5f1e05 Compare November 4, 2021 15:52
jelbourn
jelbourn approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added area: cdk/table G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 4, 2021
@devversion devversion removed the request for review from a team November 5, 2021 12:56
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@wagnermaciel wagnermaciel merged commit 853841c into angular:master Jan 10, 2022
wagnermaciel pushed a commit that referenced this pull request Jan 10, 2022
@kseamon @wagnermaciel
fix(cdk/table): Measure column width for sticky columns after new dat…
db5d8ce 
…a has rendered. (#23885)

(cherry picked from commit 853841c)
jeripeierSBB added a commit to jeripeierSBB/components that referenced this pull request Jan 13, 2022
@jeripeierSBB
fix(cdk/table): revert breaking change of CdkTable constructor
8ef0632 
With Release 13.1.2 a breaking change was introduced in cdk/table.
If a consumer has a class which extends CdkTable, compilation breaks
due to the newly introduced required constructor parameter _ngZone.
See PR: angular#23885
@jeripeierSBB jeripeierSBB mentioned this pull request Jan 13, 2022
Merged
@kyubisation
Copy link
Contributor

This introduced a breaking change. See #24202.

jeripeierSBB added a commit to jeripeierSBB/components that referenced this pull request Jan 13, 2022
@jeripeierSBB
fix(cdk/table): revert breaking change of CdkTable constructor
1eddf22 
With Release 13.1.2 a breaking change was introduced in cdk/table.
If a consumer has a class which extends CdkTable, compilation breaks
due to the newly introduced required constructor parameter _ngZone.
See PR: angular#23885
andrewseguin pushed a commit that referenced this pull request Jan 18, 2022
@jeripeierSBB
fix(cdk/table): revert breaking change of CdkTable constructor (#24202)
6c48d14 
With Release 13.1.2 a breaking change was introduced in cdk/table.
If a consumer has a class which extends CdkTable, compilation breaks
due to the newly introduced required constructor parameter _ngZone.
See PR: #23885
andrewseguin pushed a commit that referenced this pull request Jan 18, 2022
@jeripeierSBB @andrewseguin
fix(cdk/table): revert breaking change of CdkTable constructor (#24202)
c48742e 
With Release 13.1.2 a breaking change was introduced in cdk/table.
If a consumer has a class which extends CdkTable, compilation breaks
due to the newly introduced required constructor parameter _ngZone.
See PR: #23885

(cherry picked from commit 6c48d14)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/table G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kseamon @kyubisation @jelbourn @crisbeto @andrewseguin @wagnermaciel