Skip to content

build: cleanup unused dependencies #23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

build: cleanup unused dependencies #23839

merged 1 commit into from
Nov 2, 2021

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 27, 2021

Cleans up unused dependencies.

@devversion devversion added merge safe target: rc This PR is targeted for the next release-candidate labels Oct 27, 2021
@devversion devversion requested a review from a team as a code owner October 27, 2021 13:32
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 27, 2021
@devversion devversion requested a review from crisbeto October 29, 2021 12:48
crisbeto
crisbeto approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase and removed dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Oct 29, 2021
@devversion
build: cleanup unused dependencies
05e9197 
Cleans up unused dependencies.
@devversion devversion force-pushed the build/remove-unused-deps branch from f1203c5 to 05e9197 Compare November 2, 2021 20:53
@devversion devversion added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 2, 2021
@jelbourn jelbourn merged commit f8e28cb into angular:master Nov 2, 2021
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
@devversion @jelbourn
build: cleanup unused dependencies (#23839)
376c02d 
Cleans up unused dependencies.

(cherry picked from commit f8e28cb)
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Deployed dev-app to: https://ng-comp-dev--pr-23839-05e91970ddb83c850aec62cd3093fb1c-ccgkcqsy.web.app

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 3, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devversion @crisbeto @jelbourn