Skip to content

build: fix husky pre-commit hook not being executable #23822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

build: fix husky pre-commit hook not being executable #23822

merged 1 commit into from
Oct 24, 2021

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 22, 2021

Fixes that the husky pre-commit hook is not being executable,
causing it to be ignored by Husky.

@devversion
build: fix husky pre-commit hook not being executable
db302d9 
Fixes that the husky pre-commit hook is not being executable,
causing it to be ignored by Husky.
@devversion devversion added merge safe target: minor This PR is targeted for the next minor release labels Oct 22, 2021
@devversion devversion requested a review from crisbeto October 22, 2021 21:16
@devversion devversion requested a review from a team as a code owner October 22, 2021 21:16
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2021
crisbeto
crisbeto approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2021
@wagnermaciel wagnermaciel merged commit 6e97aa4 into angular:master Oct 24, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 24, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devversion @crisbeto @wagnermaciel