build: fix size-test integration tooling #23802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amysorto
added
merge safe
target: patch
google-cla
bot
added
the
cla: yes
devversion
approved these changes
Oct 20, 2021
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
Damn. The form field & date range grew on that list. That is likely due to the linker and build optimizer not being set up correctly for Ivy yet.
I'll take care of that, but as said this is no issue for comparisons right now
jelbourn
approved these changes
Oct 21, 2021
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
@devversion great observation 🥇
Contributor
|
@amysorto This has conflicts with 12.2.x. Can this be changed to target minor? |
amysorto
added
target: minor
Contributor
Author
|
No problem, just changed it |
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Oct 22, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made to be able to run
yarn approve-size-tests:rollup-plugin-node-resolveto@rollup/plugin-node-resolveplatform-browsersince these tests are no longer using View EnginenodetonodeResolveterserpackage to the latest major version (5.9.0)