Skip to content

fix(material/sort): correctly specify AriaDesciber token #23751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

fix(material/sort): correctly specify AriaDesciber token #23751

merged 1 commit into from
Oct 14, 2021

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Oct 14, 2021

Specifies the token via @Inject since the param type includes null

@jelbourn
fix(material/sort): correctly specify AriaDesciber token
429a4bc 
Specifies the token via `@Inject` since the param type includes `null`
@jelbourn jelbourn added merge safe target: patch This PR is targeted for the next patch release area: material/sort labels Oct 14, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 14, 2021
crisbeto
crisbeto approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/material/sort/sort-header.ts
private _focusMonitor: FocusMonitor,
private _elementRef: ElementRef<HTMLElement>,
/** @breaking-change 14.0.0 _ariaDescriber will be required. */
@Optional() private _ariaDescriber?: AriaDescriber | null) {
Copy link
Member

@crisbeto crisbeto Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think that we need the | null since the parameter is optional. We could decide to keep it like that instead of making it required in v14.

Copy link
Member Author

@jelbourn jelbourn Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed this was just an issue in ViewEngine- it was failing on 12.2.x but passing on master, so this PR just targets 12.2.x

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2021
@zarend zarend merged commit 47c4710 into angular:12.2.x Oct 14, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 14, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

1 similar comment
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 15, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/sort cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn @crisbeto @zarend