build: fix devserver sh_binary not working on systems with runfiles enabled #23721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled The devserver currently does not work on systems with runfiles enabled. This is commonly macOS and Linux. The devserver breaks here because we do not have a runfile tree directory built as this would cause a significant slow-down for RBE and caching. This commit ensures the runfile manifest is consulted _always_, unless the dev-server runs in a test where a runfile directory is resolved to the test directory. Inside the test action, with runfiles enabled, there would be no runfile manifest file.. causing the devserver to fail. e.g. ``` /b/f/w/bazel-out/k8-fastbuild/bin/src/material-experimental/mdc-table/e2e_tests_chromium.sh.runfiles/angular_material/tools/dev-server/dev-server_bin.sh: line 52: RUNFILES_MANIFEST_FILE: unbound variable ```
google-cla
bot
added
the
cla: yes
devversion
added
merge safe
target: rc
zarend
pushed a commit
that referenced
this pull request
Oct 11, 2021
…nabled (#23721) The devserver currently does not work on systems with runfiles enabled. This is commonly macOS and Linux. The devserver breaks here because we do not have a runfile tree directory built as this would cause a significant slow-down for RBE and caching. This commit ensures the runfile manifest is consulted _always_, unless the dev-server runs in a test where a runfile directory is resolved to the test directory. Inside the test action, with runfiles enabled, there would be no runfile manifest file.. causing the devserver to fail. e.g. ``` /b/f/w/bazel-out/k8-fastbuild/bin/src/material-experimental/mdc-table/e2e_tests_chromium.sh.runfiles/angular_material/tools/dev-server/dev-server_bin.sh: line 52: RUNFILES_MANIFEST_FILE: unbound variable ``` (cherry picked from commit 83da73f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devserver currently does not work on systems with runfiles enabled.
This is commonly macOS and Linux. The devserver breaks here because we
do not have a runfile tree directory built as this would cause a significant
slow-down for RBE and caching.
This commit ensures the runfile manifest is consulted always, unless the
dev-server runs in a test where a runfile directory is resolved to the test
directory.
Inside the test action, with runfiles enabled, there would be no runfile
manifest file.. causing the devserver to fail. e.g.