fix(material-experimental/mdc-typography): better mappings for 2014 to 2018 typography #23618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 2018 typography This PR cleans up some typography hacks in menu and table in favor of a higher level fix in the mapping code itself. Despite the naming subheading-1 in the 2014 system looks more like body-1 in the 2018 system and body-2 in the 2014 system looks more like subtitle-2 in the 2018 system. See my hackmd for the original typography mapping plan for a side-by-side comparison of the different levels & systems: https://hackmd.io/-IBynZC1QHCBefcFQyaAkA
mmalerba
added
P1
google-cla
bot
added
the
cla: yes
amysorto
pushed a commit
that referenced
this pull request
Sep 24, 2021
…o 2018 typography (#23618) * fix(material-experimental/mdc-menu): fix bold font when using 2014 typography * fix(material-experimental/mdc-typography): better mappings for 2014 to 2018 typography This PR cleans up some typography hacks in menu and table in favor of a higher level fix in the mapping code itself. Despite the naming subheading-1 in the 2014 system looks more like body-1 in the 2018 system and body-2 in the 2014 system looks more like subtitle-2 in the 2018 system. See my hackmd for the original typography mapping plan for a side-by-side comparison of the different levels & systems: https://hackmd.io/-IBynZC1QHCBefcFQyaAkA (cherry picked from commit c649f7d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.