Skip to content

fix(material-experimental/mdc-menu): use primary text color for menu icons #23608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

fix(material-experimental/mdc-menu): use primary text color for menu icons #23608

merged 1 commit into from
Sep 21, 2021

Conversation

@mmalerba
Copy link
Contributor

The spec and MDC implementation use the text color for the icon as well. This changes our MDC-based menu implementation to be in line with those.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2021
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 20, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2021
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 20, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 20, 2021
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Sep 20, 2021
wagnermaciel
wagnermaciel approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crisbeto
crisbeto approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit f282bd6 into angular:master Sep 21, 2021
wagnermaciel pushed a commit that referenced this pull request Sep 21, 2021
@mmalerba @wagnermaciel
fix(material-experimental/mdc-menu): use primary text color for menu …
a9c2da1 
…icons (#23608)

(cherry picked from commit f282bd6)
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @crisbeto @wagnermaciel