Skip to content

fix(cdk/drag-drop): sorted event emitted multiple times for single-item list #23589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix(cdk/drag-drop): sorted event emitted multiple times for single-item list #23589

merged 1 commit into from
Sep 16, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 15, 2021

Fixes that the sorted event was being emitted when the item wasn't actually being sorted when it's inside of a list with a single item.

Fixes #23575.

@crisbeto
fix(cdk/drag-drop): sorted event emitted multiple times for single-it…
ce8f778 
…em list

Fixes that the `sorted` event was being emitted when the item wasn't actually being sorted when it's inside of a list with a single item.

Fixes angular#23575.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 15, 2021
@crisbeto crisbeto requested a review from jelbourn September 15, 2021 15:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2021
jelbourn
jelbourn approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2021
@wagnermaciel
Copy link
Contributor

wagnermaciel commented Sep 16, 2021

This has merge conflicts with 12.2.x. Can this be target: minor?

@crisbeto
Copy link
Member Author

crisbeto commented Sep 16, 2021

Yep

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 16, 2021
@wagnermaciel wagnermaciel merged commit d70faa0 into angular:master Sep 16, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 17, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(Drag & Drop): cdkDropListSorted emitted multiple times with single item

3 participants

@crisbeto @wagnermaciel @jelbourn