fix(cdk/layout): breakpoint observer not firing callback on chrome in specific cases #23571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specific cases There appears to be a bug in Chrome, where if we try to use `matchMedia` on a media query that doesn't match anything on the page and a style recalculation is trigger on the `body`, the `matchMedia` callback stops firing which in turn breaks `BreakpointObserver`. These changes expand an existing workaround that we had for WebKit browsers involving inserting a dummy `style` tag on the page so that there's always at least one matching element. Fixes angular#23546.
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 16, 2021
… specific cases (#23571) There appears to be a bug in Chrome, where if we try to use `matchMedia` on a media query that doesn't match anything on the page and a style recalculation is trigger on the `body`, the `matchMedia` callback stops firing which in turn breaks `BreakpointObserver`. These changes expand an existing workaround that we had for WebKit browsers involving inserting a dummy `style` tag on the page so that there's always at least one matching element. Fixes #23546. (cherry picked from commit cfe79b8)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 17, 2021
Fixes a test failure that seems to have snuck into master because of angular#23571.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 17, 2021
Fixes a test failure that seems to have snuck into master because of angular#23571.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 17, 2021
Fixes a test failure that seems to have snuck into master because of angular#23571.
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 17, 2021
Fixes a test failure that seems to have snuck into master because of #23571.
wagnermaciel
pushed a commit
that referenced
this pull request
Sep 17, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug in Chrome, where if we try to use
matchMediaon a media query that doesn't match anything on the page and a style recalculation is triggered on thebody, thematchMediacallback stops firing which in turn breaksBreakpointObserver.These changes expand an existing workaround that we had for WebKit browsers involving inserting a dummy
styletag on the page so that there's always at least one matching element.Fixes #23546.