Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 27, 2021

Removes the APIs that were marked for removal in v13 in the material/chips module.

BREAKING CHANGE:

  • MatChipInputEvent.input has been removed. Use MatChipInputEvent.chipInput instead. (changed in g3 with copybara transform)
  • MatChipInputEvent.chipInput is now a required property. (changed in g3 with copybara transform)
  • ChipHarnessFilters.selected has been removed. Use MatChipOptionHarness together with ChipOptionHarnessFilters instead.
  • MatChipHarness.isSelected has been removed. Use MatChipOptionHarness.isSelected instead.
  • MatChipHarness.select has been removed. Use MatChipOptionHarness.select instead.
  • MatChipHarness.deselect has been removed. Use MatChipOptionHarness.deselect instead.
  • MatChipHarness.toggle has been removed. Use MatChipOptionHarness.toggle instead.
  • MatChipListHarness.selectChips has been removed. Use MatChipListboxHarness.selectChips instead.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release flag: breaking change labels Aug 27, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 27, 2021
@crisbeto crisbeto requested a review from jelbourn August 27, 2021 18:39
@crisbeto crisbeto requested review from a team and mmalerba as code owners August 27, 2021 18:39
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2021
Removes the APIs that were marked for removal in v13 in the `material/chips` module.

BREAKING CHANGE:
* `MatChipInputEvent.input` has been removed. Use `MatChipInputEvent.chipInput` instead.
* `MatChipInputEvent.chipInput` is now a required property.
* `ChipHarnessFilters.selected` has been removed. Use `MatChipOptionHarness` together with `ChipOptionHarnessFilters` instead.
* `MatChipHarness.isSelected` has been removed. Use `MatChipOptionHarness.isSelected` instead.
* `MatChipHarness.select` has been removed. Use `MatChipOptionHarness.select` instead.
* `MatChipHarness.deselect` has been removed. Use `MatChipOptionHarness.deselect` instead.
* `MatChipHarness.toggle` has been removed. Use `MatChipOptionHarness.toggle` instead.
* `MatChipListHarness.selectChips` has been removed. Use `MatChipListboxHarness.selectChips` instead.
@crisbeto crisbeto force-pushed the v13-chips-breaking-changes branch from 10db5a8 to 0fdc640 Compare August 27, 2021 18:48
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though this one might end up being pretty difficult to land in Google.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2021
@mmalerba
Copy link
Contributor

I've made some of these changes in g3 with copybara transforms. Hopefully will make it a little easier to land in the next major release

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto crisbeto closed this Jan 3, 2022
@crisbeto
Copy link
Member Author

crisbeto commented Jan 3, 2022

Closing this for now since keeping it up to date will be more work than just recreating the PR when we start doing breaking changes again.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants