fix(material-experimental/mdc-slider): remove deep imports #23451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Fixes a couple of deep imports in the `mdc-slider` package that were causing the CLI to log a warning when the package is installed.
crisbeto
force-pushed
the
mdc-slider-deep-import
branch
from
3b00946 to
ff0307d
Compare
crisbeto
changed the title
crisbeto
added
P3
devversion
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
LGTM. Might be worth checking with @wagnermaciel on this. I remember there was a reason why this was added.
|
I'm not certain but I think this might break internally due to visibility issues where Edit: @mmalerba is getting the MDC team to fix this internally so that we can land this 👍🏽 |
|
👍 I think that we would've had to fix this eventually, because the CLI logs warnings for users. |
andrewseguin
pushed a commit
that referenced
this pull request
Sep 10, 2021
Fixes a couple of deep imports in the `mdc-slider` package that were causing the CLI to log a warning when the package is installed. (cherry picked from commit 81b6b6b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of deep imports in the
mdc-sliderpackage that were causing the CLI to log a warning when the package is installed.