Skip to content

build: bump required node version #23439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

build: bump required node version #23439

merged 1 commit into from
Aug 25, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 25, 2021

Our current requirement asks for at least Node 12, however the dev-infra-private package includes some syntax that is only available in Node 14.

These changes bump the minimum required version to 14.

Fixes #23434.

@crisbeto
build: bump required node version
21dc00e 
Our current requirement asks for at least Node 12, however the `dev-infra-private` package includes some syntax that is only available in Node 14.

These changes bump the minimum required version to 14.

Fixes angular#23434.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Aug 25, 2021
@crisbeto crisbeto requested a review from a team as a code owner August 25, 2021 15:23
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 25, 2021
josephperrott
josephperrott approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 25, 2021
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Aug 25, 2021
@amysorto amysorto merged commit f40805a into angular:master Aug 25, 2021
amysorto pushed a commit that referenced this pull request Aug 25, 2021
@crisbeto @amysorto
build: bump required node version (#23439)
5306e20 
Our current requirement asks for at least Node 12, however the `dev-infra-private` package includes some syntax that is only available in Node 14.

These changes bump the minimum required version to 14.

Fixes #23434.

(cherry picked from commit f40805a)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 25, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(build): tag v12.2.2 yarn build throws ERROR with node 12

4 participants

@crisbeto @devversion @josephperrott @amysorto