Skip to content

refactor(material/core): update minimum required sass version and clean up workarounds #23414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

refactor(material/core): update minimum required sass version and clean up workarounds #23414

merged 1 commit into from
Aug 31, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 20, 2021

Updates the minimum required version of Sass and cleans up some workarounds for list.slash and math.div.

BREAKING CHANGE:

  • Material now requires at least version 1.34.0 of Sass. Version 1.38.0 is recommended.

Fixes #22915.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 20, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 20, 2021
@crisbeto crisbeto requested a review from jelbourn August 20, 2021 04:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2021
devversion
devversion approved these changes Aug 20, 2021
View reviewed changes
@crisbeto
refactor(material/core): update minimum required sass version and cle…
f3cc88f 
…an up workarounds

Updates the minimum required version of Sass and cleans up some workarounds for `list.slash` and `math.div`.

BREAKING CHANGE:
* Material now requires at least version 1.34.0 of Sass. Version 1.38.0 is recommended.

Fixes angular#22915.
@crisbeto crisbeto force-pushed the 22915/sass-minimum-version branch from fcebcef to f3cc88f Compare August 20, 2021 18:39
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 20, 2021
jelbourn
jelbourn approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 40f0674 into angular:master Aug 31, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 1, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

13.0.0

Development

Successfully merging this pull request may close these issues.

Update minimum required Sass version and remove private polyfills

4 participants

@crisbeto @jelbourn @devversion @mmalerba