Skip to content

refactor(material/form-field): remove deprecated APIs for version 13 #23389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2021
Merged

refactor(material/form-field): remove deprecated APIs for version 13 #23389

merged 1 commit into from
Aug 24, 2021

Conversation

@crisbeto
Copy link
Member

BREAKING CHANGE:

  • MatFormFieldHarness.getHarnessLoaderForPrefix has been removed. Use MatFormFieldHarness.getPrefixText instead.
  • MatFormFieldHarness.getHarnessLoaderForSuffix has been removed. Use MatFormFieldHarness.getSuffixText instead.
  • The _labelOptions parameter of the MatFormField constructor has been removed.
  • MatFormField.underlineRef has been removed.

@crisbeto
refactor(material/form-field): remove deprecated APIs for version 13
a89f9a2 
BREAKING CHANGE:
* `MatFormFieldHarness.getHarnessLoaderForPrefix` has been removed. Use `MatFormFieldHarness.getPrefixText` instead.
* `MatFormFieldHarness.getHarnessLoaderForSuffix` has been removed. Use `MatFormFieldHarness.getSuffixText` instead.
* The `_labelOptions` parameter of the `MatFormField` constructor has been removed.
* `MatFormField.underlineRef` has been removed.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release flag: breaking change labels Aug 17, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 17, 2021
@crisbeto crisbeto requested a review from mmalerba August 17, 2021 16:14
@crisbeto crisbeto requested review from a team, devversion and jelbourn as code owners August 17, 2021 16:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 17, 2021
@josephperrott josephperrott removed the request for review from a team August 17, 2021 17:00
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2021
mmalerba
mmalerba approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto merged commit 700c060 into angular:master Aug 24, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

13.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @devversion @mmalerba @amysorto