Skip to content

fix(material/chips): show required asterisk when using required validator #23379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

fix(material/chips): show required asterisk when using required validator #23379

merged 1 commit into from
Sep 7, 2021

Conversation

@crisbeto
Copy link
Member

Similar to #23362. Fixes that the required asterisk wasn't being shown when a chip list is required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 16, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 16, 2021
@crisbeto crisbeto requested a review from mmalerba August 16, 2021 05:11
@crisbeto crisbeto requested a review from jelbourn as a code owner August 16, 2021 05:11
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2021
@crisbeto
fix(material/chips): show required asterisk when using required valid…
2bd0c12 
…ator

Similar to angular#23362. Fixes that the required asterisk wasn't being shown when a chip list is required.
@crisbeto crisbeto force-pushed the chips-required-validator branch from 07b34b7 to 2bd0c12 Compare August 16, 2021 05:48
@crisbeto crisbeto requested a review from a team as a code owner August 16, 2021 05:48
@josephperrott josephperrott removed the request for review from a team August 16, 2021 16:49
mmalerba
mmalerba approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 17, 2021
@zarend zarend merged commit 6c724c1 into angular:master Sep 7, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

13.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @mmalerba @zarend