fix(material/checkbox): hide svg from assistive technology #23340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Collaborator
|
LGTM |
devversion
approved these changes
Aug 11, 2021
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. do we need the same for the checkbox in the mdc-list?
Fixes that the `svg` node inside of the checkbox might be read out by some screen readers. Fixes angular#23338.
crisbeto
force-pushed
the
23338/checkbox-hidden-svg
branch
from
f028b7e to
0e790d4
Compare
Member
Author
|
That's a good point I hadn't considered. I've added it now. |
wagnermaciel
pushed a commit
that referenced
this pull request
Aug 18, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
svgnode inside of the checkbox might be read out by some screen readers.Fixes #23338.