Skip to content

test(multiple): switch to non-deprecated test assertion context API #23326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

test(multiple): switch to non-deprecated test assertion context API #23326

merged 1 commit into from
Aug 9, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2021 •
edited
Loading

Passing in a context as the last parameter of the various test assertion functions is deprecated. These changes switch all of the tests to the new .withContext helper.

Note: setting this to P2 since it's very prone to merge conflicts.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2021
@crisbeto
test(multiple): switch to non-deprecated test assertion context API
66b17f5 
Passing in a context as the last parameter of the various test assertion functions is deprecated. These changes switch all of the tests to the new `.withContext` helper.
@crisbeto crisbeto force-pushed the test-context-migration branch from 953d3cb to 66b17f5 Compare August 7, 2021 19:44
@crisbeto crisbeto marked this pull request as ready for review August 7, 2021 19:54
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Aug 7, 2021
jelbourn
jelbourn approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 9, 2021
@andrewseguin andrewseguin added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 9, 2021
@andrewseguin andrewseguin merged commit ec7d164 into angular:master Aug 9, 2021
@Splaktar
Copy link
Contributor

Splaktar commented Aug 9, 2021

That was quick!

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @Splaktar @jelbourn @devversion @andrewseguin