Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 3, 2021

Adds a new DI token to the MDC-based card that allows consumers to set the default appearance.

Also sets up unit tests for the card.

Fixes #23298.

…pearance

Adds a new DI token to the MDC-based card that allows consumers to set the default appearance.

Also sets up unit tests for the card.

Fixes angular#23298.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Aug 3, 2021
@crisbeto crisbeto requested a review from andrewseguin August 3, 2021 15:51
@crisbeto crisbeto requested a review from mmalerba as a code owner August 3, 2021 15:51
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 3, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 17, 2021
@wagnermaciel wagnermaciel merged commit 2789d8e into angular:master Aug 18, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(mdc-card): Add default options for appearance

3 participants