Skip to content

docs: prebuilt themes incorrectly listed as dark #23291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2021
Merged

docs: prebuilt themes incorrectly listed as dark #23291

merged 1 commit into from
Aug 2, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 1, 2021

Fixes that the light/dark state of a couple of themes was mixed up.

Fixes angular/material.angular.io#1031.

@crisbeto
docs: prebuilt themes incorrectly listed as dark
44c76c5 
Fixes that the light/dark state of a couple of themes was mixed up.

Fixes angular/material.angular.io#1031.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Aug 1, 2021
@crisbeto crisbeto requested a review from jelbourn August 1, 2021 18:59
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2021
jelbourn
jelbourn approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2021
@zarend zarend merged commit 38e40f0 into angular:master Aug 2, 2021
zarend pushed a commit that referenced this pull request Aug 2, 2021
@crisbeto @zarend
docs: prebuilt themes incorrectly listed as dark (#23291)
66aec73 
Fixes that the light/dark state of a couple of themes was mixed up.

Fixes angular/material.angular.io#1031.

(cherry picked from commit 38e40f0)
zarend pushed a commit that referenced this pull request Aug 2, 2021
@crisbeto @zarend
docs: prebuilt themes incorrectly listed as dark (#23291)
0c4c22c 
Fixes that the light/dark state of a couple of themes was mixed up.

Fixes angular/material.angular.io#1031.

(cherry picked from commit 38e40f0)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 2, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Theming page lists incorrect data for Light / Dark

3 participants

@crisbeto @jelbourn @zarend