Skip to content

build: fix deprecation warning from highlightjs #23280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

build: fix deprecation warning from highlightjs #23280

merged 1 commit into from
Jul 30, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 30, 2021

Fixes the following deprecation warning that is logged by highlightjs:

Deprecated as of 10.7.0. highlight(lang, code, ...args) has been deprecated.
Deprecated as of 10.7.0. Please use highlight(code, options) instead.
https://github.com/highlightjs/highlight.js/issues/2277

@crisbeto
build: fix deprecation warning from highlightjs
2ae8f87 
Fixes the following deprecation warning that is logged by `highlightjs`:

```
Deprecated as of 10.7.0. highlight(lang, code, ...args) has been deprecated.
Deprecated as of 10.7.0. Please use highlight(code, options) instead.
highlightjs/highlight.js#2277
```
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 30, 2021
@crisbeto crisbeto requested review from a team and devversion July 30, 2021 16:07
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2021
devversion
devversion approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had that on my list too.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2021
@zarend
Copy link
Contributor

zarend commented Jul 30, 2021

I couldn't merge this into patch due to merge conflicts: 12.1.x.

@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 30, 2021
@zarend zarend merged commit c660dac into angular:master Jul 30, 2021
@zarend zarend mentioned this pull request Jul 30, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 30, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @zarend @devversion