feat(cdk/overlay): Extend cdkConnectedOverlayOrigin to support more types.
#23253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
ienzam
force-pushed
the
fix_23252_flexible_cdkConnectedOverlayOrigin
branch
from
02dfcc6 to
217ac0d
Compare
crisbeto
reviewed
Jul 28, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
You'll also have to run yarn approve-api overlay to fix the API golden failure.
ienzam
force-pushed
the
fix_23252_flexible_cdkConnectedOverlayOrigin
branch
from
217ac0d to
c351d1e
Compare
ienzam
force-pushed
the
fix_23252_flexible_cdkConnectedOverlayOrigin
branch
from
c351d1e to
cd28f52
Compare
crisbeto
reviewed
Jul 28, 2021
… types. `CdkConnectedOverlay` directive's input `cdkConnectedOverlayOrigin` only supports `CdkOverlayOrigin`. `FlexibleConnectedPositionStrategy` supports a lot more types. Add support for them. Fixes angular#23252
ienzam
force-pushed
the
fix_23252_flexible_cdkConnectedOverlayOrigin
branch
from
cd28f52 to
bf6f74b
Compare
crisbeto
added
action: merge
Contributor
|
presubmit (internal). Tests ran last night with about 100 failures, many of them are timeouts. |
zarend
added
the
presubmit failures
Contributor
tests passed on re-run |
zarend
removed
the
presubmit failures
Contributor
Author
|
Thanks for the reviews and merging! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CdkConnectedOverlaydirective's inputcdkConnectedOverlayOriginonly supportsCdkOverlayOrigin.FlexibleConnectedPositionStrategysupports a lot more types. Add support for them.Fixes #23252