Skip to content

fix(material-experimental/mdc-list): fix selected indication in high contrast mode #23242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2021
Merged

fix(material-experimental/mdc-list): fix selected indication in high contrast mode #23242

merged 1 commit into from
Jul 27, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 25, 2021

We have some special handling for single selection lists in high contrast mode which wasn't switched to the non-deprecated list styles.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 25, 2021
@crisbeto crisbeto requested a review from devversion July 25, 2021 06:02
@crisbeto crisbeto requested a review from mmalerba as a code owner July 25, 2021 06:02
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2021
devversion
devversion approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 25, 2021
Salemchilis
Salemchilis approved these changes Jul 25, 2021
View reviewed changes
Copy link

@Salemchilis Salemchilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub_Logo_White.png

@crisbeto
fix(material-experimental/mdc-list): fix selected indication in high …
91a6bf5 
…contrast mode

We have some special handling for single selection lists in high contrast mode which wasn't switched to the non-deprecated list styles.
@crisbeto crisbeto force-pushed the mdc-list-high-contrast-selected branch from 04a10ad to 91a6bf5 Compare July 26, 2021 17:15
@mmalerba mmalerba merged commit 4af0547 into angular:master Jul 27, 2021
mmalerba pushed a commit that referenced this pull request Jul 27, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-list): fix selected indication in high …
fd5f3da 
…contrast mode (#23242)

We have some special handling for single selection lists in high contrast mode which wasn't switched to the non-deprecated list styles.

(cherry picked from commit 4af0547)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 27, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

+1 more reviewer

@Salemchilis Salemchilis Salemchilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @devversion @Salemchilis @mmalerba