Skip to content

Conversation

crisbeto
Copy link
Member

Fixes that the CdkDragDrop event didn't have a way of typing the item.

Fixes #23208.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 21, 2021
@crisbeto crisbeto requested a review from jelbourn July 21, 2021 17:25
@crisbeto crisbeto requested a review from a team as a code owner July 21, 2021 17:25
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 22, 2021
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jul 23, 2021
@crisbeto crisbeto force-pushed the 23208/drag-drop-type branch from 12c08c7 to 439e2a1 Compare July 24, 2021 06:22
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jul 24, 2021
Fixes that the `CdkDragDrop` event didn't have a way of typing the item.

Fixes angular#23208.
@crisbeto crisbeto force-pushed the 23208/drag-drop-type branch from 439e2a1 to b6b5771 Compare July 26, 2021 17:15
@andrewseguin andrewseguin merged commit c03d8ac into angular:master Aug 6, 2021
andrewseguin pushed a commit that referenced this pull request Aug 6, 2021
#23209)

Fixes that the `CdkDragDrop` event didn't have a way of typing the item.

Fixes #23208.

(cherry picked from commit c03d8ac)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(CdkDragDrop): Add type bounds for item in CdkDragDrop event

4 participants