Skip to content

fix(cdk-experimental/dialog): focus restoration not working inside shadow dom #23194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

fix(cdk-experimental/dialog): focus restoration not working inside shadow dom #23194

merged 1 commit into from
Jul 19, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 18, 2021

Fixes that the experimental CDK dialog doesn't pick up the correct element to restore focus to from the shadow DOM.

@crisbeto
fix(cdk-experimental/dialog): focus restoration not working inside sh…
0f9cb6b 
…adow dom

Fixes that the experimental CDK dialog doesn't pick up the correct element to restore focus to from the shadow DOM.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 18, 2021
@crisbeto crisbeto requested a review from devversion July 18, 2021 16:58
@crisbeto crisbeto requested a review from jelbourn as a code owner July 18, 2021 16:58
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 18, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 19, 2021
@amysorto amysorto merged commit de22048 into angular:master Jul 19, 2021
amysorto pushed a commit that referenced this pull request Jul 19, 2021
@crisbeto @amysorto
fix(cdk-experimental/dialog): focus restoration not working inside sh…
9345912 
…adow dom (#23194)

Fixes that the experimental CDK dialog doesn't pick up the correct element to restore focus to from the shadow DOM.

(cherry picked from commit de22048)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @devversion @amysorto