Skip to content

fix(material/slider): Track fill style should only be applied when slider is focused, as opposed to when any ancestor is focused. #23184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix(material/slider): Track fill style should only be applied when slider is focused, as opposed to when any ancestor is focused. #23184

merged 1 commit into from
Jul 20, 2021

Conversation

@zelliott
Copy link
Collaborator

@zelliott zelliott commented Jul 16, 2021

@zelliott zelliott requested a review from mmalerba as a code owner July 16, 2021 16:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 16, 2021
@zelliott zelliott requested a review from crisbeto July 16, 2021 16:57
crisbeto
crisbeto approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 16, 2021
@zelliott zelliott added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker merge safe and removed merge safe labels Jul 20, 2021
@zelliott
Copy link
Collaborator Author

zelliott commented Jul 20, 2021

I ran an internal TGP on this change and there were only two screenshot failures, both of which are related and thus reasonable. This PR should be safe to merge.

@amysorto amysorto merged commit 3231d1d into angular:master Jul 20, 2021
amysorto pushed a commit that referenced this pull request Jul 20, 2021
@zelliott @amysorto
fix(material/slider): Style should only be applied when slider is foc…
ecac3b5 
…used. (#23184)

(cherry picked from commit 3231d1d)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 20, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zelliott @crisbeto @amysorto