build: enable automatic test module teardown #23176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
added
merge safe
P3
| beforeAll(() => { | ||
| TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting()); | ||
| TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), { | ||
| teardown: {destroyAfterEach: true} |
Member
There was a problem hiding this comment.
Can we also enable rethrowErrors everywhere as well?
Suggested change
| teardown: {destroyAfterEach: true} | |
| teardown: {destroyAfterEach: true, rethrowErrors: true} |
Member
Author
There was a problem hiding this comment.
It default to rethrowing when destroyAfterEach is enabled: https://github.com/angular/angular/blob/master/packages/core/testing/src/r3_test_bed.ts#L482
devversion
approved these changes
Jul 15, 2021
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
👍 I assume a lint rule enforcing the option is not reasonable because eventually this will be the default anyway.
Member
Author
|
Yeah, the idea is to potentially flip the default in v13. |
Angular 12.1.2 includes [opt-in automatic test module teardown](angular/angular#42566) which is similar to our logic of destroying the current fixture. These changes clean up our monkey patches and use the new option instead.
crisbeto
force-pushed
the
automatic-test-teardown-again
branch
from
bf0c248 to
4df538c
Compare
amysorto
pushed a commit
that referenced
this pull request
Jul 16, 2021
Angular 12.1.2 includes [opt-in automatic test module teardown](angular/angular#42566) which is similar to our logic of destroying the current fixture. These changes clean up our monkey patches and use the new option instead. (cherry picked from commit d090617)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 12.1.2 includes opt-in automatic test module teardown which is similar to our logic of destroying the current fixture. These changes clean up our monkey patches and use the new option instead.