Skip to content

Revert "Revert "fix(cdk/table): set default role of table to 'table'"" #23161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

Revert "Revert "fix(cdk/table): set default role of table to 'table'"" #23161

merged 1 commit into from
Jul 23, 2021

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Jul 13, 2021

Reverts #23150

@wagnermaciel wagnermaciel requested a review from jelbourn July 13, 2021 16:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 13, 2021
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Jul 13, 2021
jelbourn
jelbourn approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker labels Jul 13, 2021
@mmalerba mmalerba merged commit cfd8e78 into master Jul 23, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 23, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 23, 2021
@josephperrott josephperrott deleted the revert-23150-revert-22491-tablerole branch June 29, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagnermaciel @jelbourn @mmalerba