Skip to content

Conversation

@jeripeierSBB
Copy link
Contributor

Under the Accessibility section of the mat-paginator it's written that
a <mat-paginator> must have an aria-label.
But actually none of the found examples does provide an aria-label.

https://github.com/angular/components/blob/master/src/material/paginator/paginator.md#accessibility

Under the Accessibility section of the mat-paginator it's written that
a `<mat-paginator>` must have an aria-label.
But actually none of the found examples does provide an aria-label.

https://github.com/angular/components/blob/master/src/material/paginator/paginator.md#accessibility
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great catch. Thanks!

@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jul 1, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit 8482823 into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
…23102)

Under the Accessibility section of the mat-paginator it's written that
a `<mat-paginator>` must have an aria-label.
But actually none of the found examples does provide an aria-label.

https://github.com/angular/components/blob/master/src/material/paginator/paginator.md#accessibility
(cherry picked from commit 8482823)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants