Skip to content

fix(material-experimental/mdc-dialog): use same container selector as non-mdc version #23074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix(material-experimental/mdc-dialog): use same container selector as non-mdc version #23074

merged 1 commit into from
Jun 28, 2021

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jun 25, 2021

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue labels Jun 25, 2021
@mmalerba mmalerba requested a review from devversion as a code owner June 25, 2021 16:51
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 25, 2021
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 25, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 25, 2021
crisbeto
crisbeto approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 26, 2021
@amysorto amysorto merged commit 8b2ec8b into angular:master Jun 28, 2021
amysorto pushed a commit that referenced this pull request Jun 28, 2021
@mmalerba @amysorto
fix(material-experimental/mdc-dialog): use same container selector as…
155cfea 
… non-mdc version (#23074)

(cherry picked from commit 8b2ec8b)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 29, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @crisbeto @devversion @amysorto