build: run unit tests with partial compilation and Angular linker #22979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
build/run-unit-tests-with-linker
branch
4 times, most recently
from
6c8c9b2 to
914ee3d
Compare
devversion
added
merge safe
target: patch
crisbeto
approved these changes
Jun 16, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, although I don't have a lot of context on the Bazel code.
Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds).
devversion
force-pushed
the
build/run-unit-tests-with-linker
branch
from
914ee3d to
5cb77af
Compare
mmalerba
pushed a commit
that referenced
this pull request
Jun 18, 2021
…2979) Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds). (cherry picked from commit 77e5c21)
mmalerba
pushed a commit
that referenced
this pull request
Jun 18, 2021
…2979) Instead of running e2e tests against a linker-processed application, we run all of our unit tests using partial compilation and the Angular linker. This ensures we test our components more throroughly against the Angular linker & partial compilation. This also solves our CI flakiness issue due to the large amount of webdriver e2e tests running concurrently on CI (especially since all e2e tests ran on snapshot builds). (cherry picked from commit 77e5c21)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running e2e tests against a linker-processed application, we
run all of our unit tests using partial compilation and the Angular
linker. This ensures we test our components more throroughly against
the Angular linker & partial compilation. This also solves our CI
flakiness issue due to the large amount of webdriver e2e tests running
concurrently on CI (especially since all e2e tests ran on snapshot
builds).