test(material/chips): prevent unintentional test success #22920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 'MatChipInput' test,
MatInputModulewas not imported and therefore thematInputdirective was not interpreted.If importing
MatInputModuleinto the testing module, thematInputdirective gets applied and the test 'MatChipInput basic behavior should be aria-required if the list is required' would fail because of side effects by setting thearia-requiredattribute. Obviously,matInputdoes not remove thearia-requiredattribute, while the chips implementation is doing so (chips is interpreting false as null, whilematInputleaves 'false' as-is).