Skip to content

test(material/autocomplete): refactor variable type to const in autocomplete component unit tests #22916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2021
Merged

test(material/autocomplete): refactor variable type to const in autocomplete component unit tests #22916

merged 1 commit into from
Jun 9, 2021

Conversation

@nitinmalave
Copy link
Contributor

@nitinmalave nitinmalave commented Jun 8, 2021

Opening this PR as it is required to:

  • Refactor variables in autocomplete component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • All tests within a spec should be consistent with all other tests in repo.

@nitinmalave nitinmalave requested a review from crisbeto as a code owner June 8, 2021 04:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2021
crisbeto
crisbeto approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jun 8, 2021
@nitinmalave
Copy link
Contributor Author

nitinmalave commented Jun 8, 2021

I will fix the ci build fail issue.

@nitinmalave
test(material/autocomplete): refactor variable type to const in autoc…
488bb9d 
…omplete component unit tests

style(material/autocomplete): fix tslint max-size exceeded issue in ci build
@nitinmalave nitinmalave force-pushed the refactor-autocomplete-unit-tests branch from 30aa3fb to 488bb9d Compare June 8, 2021 05:07
@andrewseguin andrewseguin merged commit 76186ad into angular:master Jun 9, 2021
andrewseguin pushed a commit that referenced this pull request Jun 9, 2021
@nitinmalave @andrewseguin
test(material/autocomplete): refactor variable type to const in autoc…
ffad0a4 
…omplete component unit tests (#22916)

style(material/autocomplete): fix tslint max-size exceeded issue in ci build

(cherry picked from commit 76186ad)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 10, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitinmalave @crisbeto @andrewseguin