Skip to content

docs(cdk/scrolling): note that ViewportRuler.change emits outside the zone #22801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

docs(cdk/scrolling): note that ViewportRuler.change emits outside the zone #22801

merged 1 commit into from
May 26, 2021

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented May 25, 2021

Fixes #8279

@jelbourn jelbourn added docs This issue is related to documentation area: cdk/scrolling labels May 25, 2021
@jelbourn jelbourn requested a review from mmalerba May 25, 2021 23:32
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 25, 2021
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe labels May 25, 2021
mmalerba
mmalerba approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
Copy link
Contributor

mmalerba commented May 25, 2021

looks like you might need to rebase to make CI happy

crisbeto
crisbeto approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn force-pushed the viewprt-ruler-outzone branch from 290305c to 86cb265 Compare May 26, 2021 19:29
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label May 26, 2021
@mmalerba mmalerba merged commit 298fed2 into angular:master May 26, 2021
mmalerba pushed a commit that referenced this pull request May 26, 2021
@jelbourn @mmalerba
docs(cdk/scrolling): note that ViewportRuler.change emits outside the (…
f9990fe 
…#22801)

zone

Fixes #8279

(cherry picked from commit 298fed2)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 26, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/scrolling cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cdk] indicate in docs which utilities operate outside NgZone

3 participants

@jelbourn @mmalerba @crisbeto