Skip to content

fix(material-experimental/mdc-table): add background inherit to header cells #22751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2021
Merged

fix(material-experimental/mdc-table): add background inherit to header cells #22751

merged 1 commit into from
May 29, 2021

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 21, 2021

MDC explicitly sets a color on the header cells - this aligns all cells to be inheriting from the table element itself (which uses background card by default)

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2021
@andrewseguin andrewseguin requested a review from jelbourn May 21, 2021 16:51
@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels May 21, 2021
@andrewseguin andrewseguin requested review from crisbeto and mmalerba May 21, 2021 17:00
crisbeto
crisbeto approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 21, 2021
@mmalerba mmalerba merged commit ade0901 into angular:master May 29, 2021
mmalerba pushed a commit that referenced this pull request May 29, 2021
@andrewseguin @mmalerba
fix(material-experimental/mdc-table): add background inherit to heade…
6b5d8e4 
…r cells (#22751)

(cherry picked from commit ade0901)
Salemchilis
Salemchilis approved these changes May 29, 2021
View reviewed changes
Copy link

@Salemchilis Salemchilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salem(s)

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 29, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

+1 more reviewer

@Salemchilis Salemchilis Salemchilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewseguin @crisbeto @Salemchilis @mmalerba