fix(material-experimental/mdc-progress-spinner): set line-height #22668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
May 11, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM. Do we need the same fix for the non-MDC spinner?
Contributor
Author
|
Nah, only affects the MDC one (came up during a migration) |
mmalerba
pushed a commit
that referenced
this pull request
May 13, 2021
) (cherry picked from commit 8ba7148)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the line-height is much larger than the diameter, the spinner breaks.
Example: https://stackblitz.com/edit/angular-rgtfre-k7iryu?file=src/app/progress-spinner-overview-example.html
This explicitly sets it to 0 rather than whatever it would inherit.
Filed an issue with MDC: material-components/material-components-web#7118