Skip to content

fix(material-experimental/mdc-slide-toggle): set $deprecated-suffix on import #22645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2021
Merged

fix(material-experimental/mdc-slide-toggle): set $deprecated-suffix on import #22645

merged 4 commits into from
May 13, 2021

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 8, 2021 •
edited
Loading

No description provided.

@mmalerba mmalerba requested a review from crisbeto as a code owner May 8, 2021 21:13
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2021
@mmalerba mmalerba added blocked This issue is blocked by some external factor, such as a prerequisite PR action: merge The PR is ready for merge by the caretaker merge safe and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 8, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2021
@mmalerba mmalerba added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 8, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2021
crisbeto
crisbeto approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to do the same for other /deprecated imports?

@mmalerba
Copy link
Contributor Author

mmalerba commented May 10, 2021

Currently no, but maybe in the future if MDC winds up using this as a template for the other migrations. This PR is copied from a CL they sent us internally. I still need to verify that these CI issues will go away once their CL lands

@mmalerba mmalerba requested a review from a team as a code owner May 10, 2021 18:52
crisbeto
crisbeto reviewed May 10, 2021
View reviewed changes
@mmalerba mmalerba force-pushed the mdc-update branch 2 times, most recently from 63d2515 to 4b6ea9d Compare May 10, 2021 21:17
@mmalerba mmalerba changed the title fix(material-experimental/mdc-switch): set $deprecated-suffix on import fix(material-experimental/mdc-slide-toggle): set $deprecated-suffix on import May 10, 2021
@josephperrott josephperrott removed the request for review from a team May 11, 2021 15:50
@mmalerba mmalerba added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 11, 2021
@mmalerba mmalerba removed blocked This issue is blocked by some external factor, such as a prerequisite PR merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 12, 2021
@mmalerba mmalerba merged commit c04bd21 into angular:master May 13, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 13, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmalerba @crisbeto