Skip to content

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 12, 2021

In Angular CLI version 12, JSON Schema draft-04 will no longer be supported. Therefore id will need to be updated to $id.

More information about this draft can be found https://json-schema.org/draft-07/json-schema-release-notes.html

Note: This change is backwards compatible.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2021
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 12, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2021
@google-cla
Copy link

google-cla bot commented Apr 12, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

In Angular CLI version 12, JSON Schema `draft-04` will no longer be supported. Therefore `id` will need to be updated to `$id`.

- We replace id with $id, this no longer valid in draft-07.
- Replace all $schemas to http://json-schema.org/draft-07/schema, this is needed to "pin" the schema to draft-07.

More information about this draft can be found https://json-schema.org/draft-07/json-schema-release-notes.html
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release area: cdk/schematics cdk/schematics is *not* a public API area: ng-generate Schematics that generate code in user projects and removed target: patch This PR is targeted for the next patch release area: cdk/schematics cdk/schematics is *not* a public API labels Apr 12, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels Apr 12, 2021
@mmalerba mmalerba merged commit 55a2a6c into angular:master Apr 12, 2021
@alan-agius4 alan-agius4 deleted the schemas-update branch April 12, 2021 17:24
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: ng-generate Schematics that generate code in user projects cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants