Skip to content

build: add lint rule for unused Sass imports #22454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

build: add lint rule for unused Sass imports #22454

merged 1 commit into from
Apr 12, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 11, 2021

Since all the imports are namespaced now, it's trivial to figure out whether they're being used. These changes add a custom lint rule and fix all of the failures.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: major This PR is targeted for the next major release labels Apr 11, 2021
@crisbeto crisbeto requested review from devversion and jelbourn April 11, 2021 12:44
@crisbeto crisbeto requested review from a team, andrewseguin and mmalerba as code owners April 11, 2021 12:44
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 11, 2021
@crisbeto
build: add lint rule for unused Sass imports
fe6a31e 
Since all the imports are namespaced now, it's trivial to figure out whether they're being used. These changes add a custom lint rule and fix all of the failures.
@crisbeto crisbeto force-pushed the unused-sass-imports branch from 1f5ea0a to fe6a31e Compare April 11, 2021 12:57
@josephperrott josephperrott removed the request for review from a team April 12, 2021 14:50
jelbourn
jelbourn approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 12, 2021
@mmalerba mmalerba merged commit 3318877 into angular:master Apr 12, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 13, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @devversion @mmalerba