feat(material/schematics): add migration to switch to the new theming API #22304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
commented
Mar 21, 2021
crisbeto
commented
Mar 21, 2021
jelbourn
reviewed
Mar 22, 2021
devversion
approved these changes
Mar 22, 2021
Member
|
I think that's okay for now- we'll see how rollout goes and whether we need to do anything special for now-really-private APIs. |
crisbeto
force-pushed
the
theming-schematic
branch
from
9c75771 to
d95e8d6
Compare
Member
Author
|
@jelbourn I've expanded the migration to handle any |
crisbeto
force-pushed
the
theming-schematic
branch
from
d95e8d6 to
ae1c4e9
Compare
jelbourn
reviewed
Mar 24, 2021
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
Looks good overall, just one main comment about identifying @use namespaces
… API Adds an `ng-generate` schematic that will switch over existing stylesheets to the new `@use`-based API. Furthermore, the migration code is set up in a way that should allow us to run it in g3 if necessary.
crisbeto
force-pushed
the
theming-schematic
branch
from
ae1c4e9 to
517cf91
Compare
Member
Author
|
I've reworked it based on the latest set of feedback. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 28, 2021
This is follow-up from the PR that introduced the theming API migration (angular#22304 (comment)). It renames a few variables in the CDK to align them with the new API.
wagnermaciel
pushed a commit
that referenced
this pull request
Mar 30, 2021
This is follow-up from the PR that introduced the theming API migration (#22304 (comment)). It renames a few variables in the CDK to align them with the new API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ng-generateschematic that will switch over existing stylesheets to the new@use-based API. Furthermore, the migration code is set up in a way that should allow us to run it in g3 if necessary.