Skip to content

fix(google-maps): initialize directions service lazily #22302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(google-maps): initialize directions service lazily #22302

merged 1 commit into from
Mar 23, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 20, 2021

Similar to #22159. Only initializes the Google Maps DirectivesService when calling route, because doing so in the constructor might be too early.

@crisbeto
fix(google-maps): initialize directions service lazily
813a980 
Similar to angular#22159. Only initializes the Google Maps `DirectivesService` when calling `route`, because doing so in the constructor might be too early.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 20, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2021
@crisbeto crisbeto requested a review from jelbourn March 20, 2021 13:51
jelbourn
jelbourn approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 22, 2021
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 23, 2021
@andrewseguin andrewseguin merged commit 588a506 into angular:master Mar 23, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 23, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @andrewseguin