Skip to content

feat(material-experimental/mdc-card): add appearance input #22070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

feat(material-experimental/mdc-card): add appearance input #22070

merged 2 commits into from
Mar 2, 2021

Conversation

@annieyw
Copy link
Contributor

@annieyw annieyw commented Mar 1, 2021

Add appearance input to support outline variant of card

Fixes #21548

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Mar 1, 2021
@annieyw annieyw requested a review from mmalerba as a code owner March 1, 2021 19:35
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2021
crisbeto
crisbeto reviewed Mar 1, 2021
View reviewed changes
crisbeto
crisbeto approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@wagnermaciel wagnermaciel merged commit 4b1ee6f into angular:master Mar 2, 2021
@annieyw annieyw deleted the card-outline branch March 2, 2021 16:54
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 2, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(mdc-card): add appearance input

3 participants

@annieyw @crisbeto @wagnermaciel