refactor(material-experimental/mdc-core): clean up remaining @import usages #22045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
mmalerba
approved these changes
Mar 1, 2021
Contributor
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
LGTM, though I imagine these will keep popping up unless we add a lint check
Member
Author
|
Yeah, I plan on adding a lint check once this is landed. |
jelbourn
approved these changes
Mar 1, 2021
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, super readable with the mdc- aliases
Contributor
|
Needs rebase @crisbeto |
crisbeto
force-pushed
the
sass-modules-cleanup
branch
from
5b4c067 to
a2a32f7
Compare
Member
Author
|
Rebased. |
crisbeto
force-pushed
the
sass-modules-cleanup
branch
from
a2a32f7 to
11130e8
Compare
andrewseguin
approved these changes
Mar 5, 2021
crisbeto
force-pushed
the
sass-modules-cleanup
branch
from
11130e8 to
54068f1
Compare
…usages Replaces all the remaining `@import` usages with `@use`.
crisbeto
force-pushed
the
sass-modules-cleanup
branch
from
54068f1 to
153c3ac
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all the remaining
@importusages with@use.