refactor(material/theming): normalize config in all typography mixins for mdc components #21935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
andrewseguin,
crisbeto and
devversion
as code owners
google-cla
bot
added
the
cla: yes
mmalerba
force-pushed
the
typog-norm-mdc
branch
from
8353d9e to
f5a8190
Compare
crisbeto
approved these changes
Feb 18, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, but the CI is failing.
mmalerba
force-pushed
the
typog-norm-mdc
branch
3 times, most recently
from
f143f1c to
2b7ddd0
Compare
mmalerba
force-pushed
the
typog-norm-mdc
branch
from
2b7ddd0 to
a608a2f
Compare
andrewseguin
approved these changes
Mar 5, 2021
Contributor
andrewseguin
left a comment
andrewseguin
left a comment
There was a problem hiding this comment.
LGTM - should this change be made in internal Google Material components as well?
Contributor
Author
|
Yeah, I need to look into the screenshot diffs for this PR because I wasn't really expecting any. But once it's in we should do the same for Google Material components |
Contributor
|
@mmalerba needs rebase |
mmalerba
added
the
P2
for mdc components This is split off of angular#21778 which covers non-MDC conmponents as well
… mixins for mdc components
… mixins for mdc components
… mixins for mdc components
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off of #21778 which covers non-MDC conmponents as well